somehow not adding the returnurl param went missing#111
Open
rschrieken wants to merge 1 commit intoStackExchange:masterfrom
Open
somehow not adding the returnurl param went missing#111rschrieken wants to merge 1 commit intoStackExchange:masterfrom
rschrieken wants to merge 1 commit intoStackExchange:masterfrom
Conversation
Contributor
|
Note for self: we need to ensure there's not an open redirect here on the server implementation (relative or current domain should be allowed only) - want to investigate this before merging in another path to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes https://meta.stackexchange.com/questions/256042/sede-login-redirects-to-front-page-rather-than-returning
I've simply copied the build-up of the returnUrl query parameter as it was done in Views\Account\LogInActiveDirectory.cshtml
Tested with the SE OpenId provider. Any other provider that supports keeping the returnurl intact would work similar.